Skip to content

fix(vsce): align model selection with code package and remove env logic from /config#1336

Merged
lewis617 merged 1 commit into
mainfrom
fix-fast-model-selection-vsce
Jul 3, 2026
Merged

fix(vsce): align model selection with code package and remove env logic from /config#1336
lewis617 merged 1 commit into
mainfrom
fix-fast-model-selection-vsce

Conversation

@lewis617

@lewis617 lewis617 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove fast model dropdown from /model dialog to match code package behavior (code package only selects a single model)
  • Align setModel flow with code package: use agent.setModel() for hot update + persist to ~/.wave/settings.json, instead of VS Code globalState save + agent destroy/recreate
  • Remove all env var logic from /config dialog: no more env* fields in ConfigurationData, no env placeholder text, no maskSecret helper

Changes

Model selection alignment (/model)

  • ModelDialog.tsx: removed fast model <select> dropdown, only model select remains
  • messageHandler.ts: handleSetModel now calls updateAllSessionsModel(model)agent.setModel() on all sessions
  • chatSession.ts: added setModel() method delegating to agent.setModel()
  • chatProvider.ts: added updateAllSessionsModel callback
  • messageHandler.ts: handleGetConfiguredModels no longer sends currentFastModel

Env logic removal (/config)

  • configurationService.ts: removed env* fields from interface, removed maskSecret(), removed env var reads from loadConfiguration()
  • types/index.ts: removed env* fields from ConfigurationData type
  • ConfigDialog.tsx: placeholders changed to plain text (no env references)
  • StatusDialog.tsx: displays configurationData.* directly, no env fallback
  • LoginDialog.tsx: serverUrl no longer falls back to envServerUrl, placeholder changed to plain text

Tests

  • modelDropdown.test.tsx: removed all fast model assertions, added assertion that #fast-model-select does not exist
  • model-dialog.demo.ts: removed env mock data and fast-model-select assertion

Test Results

  • 191/191 VSCE unit tests pass
  • 30/30 e2e demo tests pass
  • 46/46 agent-sdk tests pass

…ic from /config

- Remove fast model dropdown from /model dialog to match code package
- Change setModel to use agent.setModel() (hot update) instead of globalState save + agent destroy/recreate
- Remove all env* fields from ConfigurationData and related components
- Remove env placeholder text from ConfigDialog, LoginDialog, StatusDialog
- Remove maskSecret helper and env var reads from configurationService
- Update tests and e2e demos to match new behavior
@lewis617 lewis617 merged commit ff149d9 into main Jul 3, 2026
1 check passed
@lewis617 lewis617 deleted the fix-fast-model-selection-vsce branch July 3, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant