fix(vsce): align model selection with code package and remove env logic from /config#1336
Merged
Merged
Conversation
…ic from /config - Remove fast model dropdown from /model dialog to match code package - Change setModel to use agent.setModel() (hot update) instead of globalState save + agent destroy/recreate - Remove all env* fields from ConfigurationData and related components - Remove env placeholder text from ConfigDialog, LoginDialog, StatusDialog - Remove maskSecret helper and env var reads from configurationService - Update tests and e2e demos to match new behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/modeldialog to match code package behavior (code package only selects a single model)agent.setModel()for hot update + persist to~/.wave/settings.json, instead of VS Code globalState save + agent destroy/recreate/configdialog: no moreenv*fields inConfigurationData, no env placeholder text, nomaskSecrethelperChanges
Model selection alignment (
/model)ModelDialog.tsx: removed fast model<select>dropdown, only model select remainsmessageHandler.ts:handleSetModelnow callsupdateAllSessionsModel(model)→agent.setModel()on all sessionschatSession.ts: addedsetModel()method delegating toagent.setModel()chatProvider.ts: addedupdateAllSessionsModelcallbackmessageHandler.ts:handleGetConfiguredModelsno longer sendscurrentFastModelEnv logic removal (
/config)configurationService.ts: removedenv*fields from interface, removedmaskSecret(), removed env var reads fromloadConfiguration()types/index.ts: removedenv*fields fromConfigurationDatatypeConfigDialog.tsx: placeholders changed to plain text (no env references)StatusDialog.tsx: displaysconfigurationData.*directly, no env fallbackLoginDialog.tsx: serverUrl no longer falls back toenvServerUrl, placeholder changed to plain textTests
modelDropdown.test.tsx: removed all fast model assertions, added assertion that#fast-model-selectdoes not existmodel-dialog.demo.ts: removed env mock data and fast-model-select assertionTest Results