fix: skip empty SSE data lines to avoid spurious parse errors#1326
Merged
Conversation
Servers/proxies send empty data: lines as keepalive heartbeats every ~12s.
JSON.parse("") threw SyntaxError, flooding app.log with noise like:
[ERROR] Failed to parse stream chunk {"error":{},"data":""}
- Skip empty data lines before JSON.parse
- Log actual error message instead of empty object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
app.logwas flooded with errors every ~12s:Root Cause
Servers/proxies send empty
data:lines as SSE keepalive heartbeats. The streaming parser inopenaiClient.tsattemptedJSON.parse("")on these empty payloads, throwing aSyntaxErroreach time. TheSyntaxErrorobject'smessageproperty is non-enumerable, so it serialized as{}in the log.Fix
if (!data) continue) before attemptingJSON.parse, silently ignoring keepalive heartbeats.e instanceof Error ? e.message : String(e)) instead of the raw error object, so any future parse failures are diagnosable.Testing
openaiClienttests pass.