fix: yield event loop before sendAIMessage recursion to prevent OOM#1325
Merged
Conversation
…hange All MemoryService methods (getAutoMemoryContent, getUserMemoryContent, readMemoryFile, getCombinedMemoryContent) now cache their results after first read and return cached values on subsequent calls within the same session. Cache is invalidated via clearCache() wired into the onSessionIdChange callback in containerSetup.ts, which fires on clear, compact, truncate, and restore. - Convert all cache fields to null-sentinel pattern (string | null) - Add _cachedAutoMemoryContent field - Cache readMemoryFile() and getUserMemoryContent() independently - Wire memoryService.clearCache() into onSessionIdChange callback - Remove redundant clearCache() call in Agent.clearMessages() - Add tests for caching and cache invalidation behavior
Memory caching made getAutoMemoryContent return synchronously on cache hits, turning sendAIMessage recursion into a pure microtask chain. This starved the event loop — the 50ms abort setTimeout (a macrotask) never fired, causing unbounded recursion (depth 2400+) and OOM. Fix: await setImmediate before recursing to let macrotasks (abort signals, timers) process. Re-check abort status after yielding. Ref: #1324 (recursive → iterative refactor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Memory caching made
getAutoMemoryContentreturn synchronously on cache hits, turningsendAIMessagerecursion into a pure microtask chain. This starved the event loop — the 50ms abortsetTimeout(a macrotask) never fired, causing unbounded recursion (depth 2400+) and OOM.Fix
await setImmediatebefore recursing to let macrotasks (abort signals, timers) process. Re-check abort status after yielding.Verification
FATAL ERROR: Reached heap limitRef