Address large data table review findings#631
Merged
Merged
Conversation
novykh
force-pushed
the
fix/large-data-table-review
branch
from
775db82 to
89e86a0
Compare
ktsaou
approved these changes
Jul 13, 2026
ktsaou
requested changes
Jul 13, 2026
ktsaou
left a comment
ktsaou
left a comment
Member
There was a problem hiding this comment.
Two blocking regressions remain on the current head: selection-state rendering scales with the full data set, and the header-specific tooltip ownership contract is replaced by the generic body-cell contract. Both undermine the large-table work and need to be addressed before merge. The sorting-cache trade-off discussed separately is non-blocking.
ktsaou
approved these changes
Jul 13, 2026
ktsaou
left a comment
ktsaou
left a comment
Member
There was a problem hiding this comment.
The header-tooltip ownership regression is fixed. The selection discussion is resolved: the complete render path already carried the source traversal, while this change preserves correct disabled-row semantics. Focused table tests pass; approved pending the required CI check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.