Skip to content

ADR-0156: immutable typed cross-entity reference contracts #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikstern wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ADR-0156: immutable typed cross-entity reference contracts #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/adrs/0149-free-boolean-cross-entity-guards.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ADR-0149: Free-boolean cross-entity guards in the L1 model check

- Status: Proposed
- Status: Accepted
- Date: 2026-06-22
- Deciders: Temper core maintainers
- Related:
Expand Down
2 changes: 1 addition & 1 deletion docs/adrs/0150-composite-cross-entity-verification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ADR-0150: Always-On Composite Cross-Entity Verification

- Status: Proposed
- Status: Accepted

@greptile-apps greptile-apps Bot Jul 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Accepted status overstates coverage

This marks ADR-0150 Accepted and ADR-0156 calls it already shipped, while ADR-0156 also documents that the current directed-reachability planner omits upstream members such as Z in Z -> A. Readers therefore cannot distinguish the implemented gating behavior from the still-unimplemented complete weak-component coverage promised by ADR-0150.

Knowledge Base Used: Temper spec format, codegen, and verification

Prompt To Fix With AI 
This is a comment left during a code review.
Path: docs/adrs/0150-composite-cross-entity-verification.md
Line: 3

Comment:
**Accepted status overstates coverage**

This marks ADR-0150 Accepted and ADR-0156 calls it already shipped, while ADR-0156 also documents that the current directed-reachability planner omits upstream members such as `Z` in `Z -> A`. Readers therefore cannot distinguish the implemented gating behavior from the still-unimplemented complete weak-component coverage promised by ADR-0150.

**Knowledge Base Used:** [Temper spec format, codegen, and verification](https://app.greptile.com/arni-labs/-/custom-context/knowledge-base/nerdsane/temper/-/docs/temper-spec.md)

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Codex Fix in Cursor

- Date: 2026-06-22
- Deciders: Temper core maintainers
- Related:
Expand Down
Loading