Skip to content

perf: optimize unread notification count query #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ayush-0918 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: optimize unread notification count query #210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d532e6
perf: optimize unread notification count query
Ayush-0918 Jul 7, 2026
61e7783
style: format notification service with black
Ayush-0918 Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions backend/app/services/notification_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import uuid
from datetime import datetime

from sqlalchemy import select
from sqlalchemy import func, select
from sqlalchemy.orm import Session

from app.models.notification import Notification
Expand Down Expand Up @@ -91,12 +91,16 @@ def unread_count(
recipient_id: uuid.UUID,
) -> int:

stmt = select(Notification).where(
Notification.recipient_id == recipient_id,
Notification.is_read.is_(False),
stmt = (
select(func.count())
.select_from(Notification)
.where(
Notification.recipient_id == recipient_id,
Notification.is_read.is_(False),
)
)

return len(list(db.scalars(stmt)))
return db.scalar(stmt) or 0

@staticmethod
def mark_as_read(
Expand Down