Feat/improve empty search#205
Open
dristicg wants to merge 9 commits into
Open
Conversation
Owner
|
Some of the required CI checks is currently failing. Please take a look at the workflow logs, identify the cause, and push a fix. Once all required checks pass, I'll review and proceed with the PR. |
added 7 commits
July 8, 2026 00:04
- Add working-directory: frontend to frontend-ci.yml (was running npm ci from root) - Fix cache-dependency-path to frontend/package-lock.json - Regenerate package-lock.json via npm install for consistency - Remove all __pycache__ files from git tracking - Add __pycache__/ and *.pyc to root .gitignore
lottie-react's Lottie component doesn't properly fill aspect-ratio containers. Replaced aspect-square with explicit h-* classes matching the w-* breakpoints so the container has a definite height.
lottie-react's Lottie component wasn't rendering. Switched to lottie-web directly via useEffect + ref for reliable control.
Same fix as _app.tsx — lottie-react Lottie wrapper wasn't rendering. Switched to lottie-web via useEffect + ref for reliable animation.
lottie-web was only a transitive dep of lottie-react, which could cause Vite dep pre-bundling issues. Install it directly so Vite always optimizes and resolves it properly.
- Remove -mt-2 negative margin from heading, replace with mt-6 for more space between animation and text - Add bg-background and [&_svg]:bg-transparent to animation container so background matches the page - Add active:scale-95 + transition-transform to buttons for click feedback animation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(search): implement responsive EmptySearchState fallback for project search (#142)
Description
This PR fixes the empty directory layout bug on the Project Search view (/projects). When a user types a query or toggles status filters that return zero results, the app now displays a polished, context-aware empty state rather than a blank space. It also provides a quick reset action to instantly clear active search filters and inputs.
Linked Issue
Closes #142
Screenshots
for this i don't have previous image
Testing Performed
Zero State Trigger: Verified that renders only when the filtered project list array length reaches exactly zero.
Filter Reset Action: Tested the "Clear Filters" button callback to ensure it resets both the text query input (q) and active drop-down filters simultaneously, bringing the full project grid back immediately.
Responsiveness: Verified mobile layout behavior using Chrome DevTools across responsive breakpoints.
Build Verification: Ran npm run lint and npm run build locally in the frontend workspace folder to guarantee zero TypeScript or bundle check failures.