Skip to content

feat: add empty state for notifications #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nitikanirwani wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add empty state for notifications #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 37 additions & 8 deletions frontend/src/routes/_app.notifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { useQuery } from "@tanstack/react-query";
import { notificationsService } from "@/services";
import { Card } from "@/components/shared/primitives";
import { cn } from "@/lib/utils";
import { Bell } from "lucide-react";

export const Route = createFileRoute("/_app/notifications")({
head: () => ({
Expand All @@ -15,7 +16,10 @@ export const Route = createFileRoute("/_app/notifications")({
});

function NotificationsPage() {
const { data = [] } = useQuery({ queryKey: ["notifications"], queryFn: notificationsService.list });
const { data = [] } = useQuery({
queryKey: ["notifications"],
queryFn: notificationsService.list,
});
return (
<div className="space-y-4">
<div className="flex items-center justify-between">
Expand All @@ -29,13 +33,38 @@ function NotificationsPage() {
</div>
<Card>
<ul className="divide-y divide-border">
{data.map((n) => (
<li key={n.id} className={cn("flex items-center gap-3 px-4 py-3", n.unread && "bg-primary-soft/30")}>
<span className={cn("h-2 w-2 shrink-0 rounded-full", n.unread ? "bg-primary" : "bg-transparent")} />
<p className="min-w-0 flex-1 text-[13px] text-foreground">{n.text}</p>
<span className="text-[11px] text-muted-foreground">{n.ago}</span>
</li>
))}
{data.length === 0 ? (
<div className="flex flex-col items-center justify-center py-12 text-center">
<Bell className="mb-4 h-12 w-12 text-muted-foreground" />
<h3 className="text-lg font-semibold">No notifications yet</h3>
<p className="mt-2 text-sm text-muted-foreground">
You're all caught up! New notifications will appear here.
</p>
</div>
) : (
data.map((n) => (
<li
key={n.id}
className={cn(
"flex items-center gap-3 px-4 py-3",
n.unread && "bg-primary-soft/30"
)}
>
<span
className={cn(
"h-2 w-2 shrink-0 rounded-full",
n.unread ? "bg-primary" : "bg-transparent"
)}
/>
<p className="min-w-0 flex-1 text-[13px] text-foreground">
{n.text}
</p>
<span className="text-[11px] text-muted-foreground">
{n.ago}
</span>
</li>
))
)}
</ul>
</Card>
</div>
Expand Down
Loading