Containerize#127
Open
PineND wants to merge 17 commits into
Open
Conversation
andrewpbray
reviewed
Apr 23, 2025
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Set CRAN repository to use precompiled binaries | ||
| ENV CRAN_REPO="https://packagemanager.posit.co/cran/latest" |
Collaborator
There was a problem hiding this comment.
change this to reference recent fixed day.
andrewpbray
reviewed
Apr 30, 2025
| ENV CRAN_REPO="https://packagemanager.posit.co/cran/latest" | ||
| ENV CRAN_REPO="https://packagemanager.posit.co/cran/2025-04-22" | ||
|
|
||
| ENV NEMOGB_PKG="nemogb-dev/nemogb-r@main" |
Collaborator
There was a problem hiding this comment.
Similarly to the R packages, should this be tagged to a release? Otherwise we can't look at the dockerfile and know what version of the package its running.
andrewpbray
reviewed
Apr 30, 2025
| @@ -34,26 +31,18 @@ RUN R -e "options(repos=c(CRAN='$CRAN_REPO')); \ | |||
| # Additional packages needed for the nemogb-app | |||
Collaborator
There was a problem hiding this comment.
What about installing the app here, as an R package?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.