Point the numba 0.43 removerefctpass link at the path that existed then - #65
Open
nelson2005 wants to merge 1 commit into
Open
Point the numba 0.43 removerefctpass link at the path that existed then#65nelson2005 wants to merge 1 commit into
nelson2005 wants to merge 1 commit into
Conversation
The link used the modern numba/core/ layout against tag 0.43.0, which predates it, so it 404s. At 0.43.0 the file is numba/targets/removerefctpass.py; numba/core/removerefctpass.py first resolves at 0.50.0. The sentence's claim is unaffected and checks out: the file at 0.43.0 contains both _accepted_nrtfns and _legalize, so the pass really has carried that logic since 0.43. The other five removerefctpass links on this page pin 0.61.2, where numba/core/ is correct, and are unchanged.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
Pull request overview
Fixes a broken historical GitHub link in the UDAF design documentation by pointing the numba 0.43.0 removerefctpass reference at the correct pre-numba/core/ source-tree location, helping keep scheduled link-check runs green.
Changes:
- Update the
numba 0.43 (2019)removerefctpasslink target fromnumba/core/removerefctpass.pytonumba/targets/removerefctpass.py.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/test_ducklib.mdline 163 linksremoverefctpassat tag0.43.0using the modernnumba/core/layout, which that tag predates, so it 404s:At
0.43.0the file is atnumba/targets/removerefctpass.py— verified 200, and the complete0.43.0tree ("truncated": false) contains no other path matchingrefct.numba/core/removerefctpass.pyfirst resolves at0.50.0(404 at0.47.0and0.49.0).The sentence's claim is unaffected and checks out independently: the file at
0.43.0contains both_accepted_nrtfnsand_legalize, so the pass really has carried that logic since 0.43.The other five
removerefctpasslinks on this page pin0.61.2, wherenumba/core/is correct. They are unchanged.Verified with lychee 0.24.2 over the same scope the scheduled job uses — the repo is now link-clean:
This is the one real failure behind the weekly scheduled link-check being red since 2026-06-29. Fork-side companion: #64 adds the
failIfEmpty: falsethe shared template carries.