Resuming bug fix + Variable refactor#30
Open
MrPowley wants to merge 1 commit into
Open
Conversation
- Fixed bug when trying to resume final-pass with existing but empty enc file. - Renamed 'vspipe_resume_value' to 'vspipe_resume_frame' and made its type (int) consitent across functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed the
vspipe_resume_valueto a more explanatoryvspipe_resume_frameand made sure it had a consistent type (int) to avoid other possible errors.Fixed a bug where if the final pass encoding were to be canceled after file creation and before any data was written to it, auto-boost would try to load the file with ffms2 which would result in an error. I added an exception to catch the error so the program can re-do the whole encoding stage from the beginning.