Codexによる実装計画レビューループ機能の初期実装

.gitignore

@@ -142,3 +142,6 @@ vite.config.ts.timestamp-*
 
 # MCP
 .mcp.json
+
+# AIに渡すプロンプトファイルを置く場所
+user-prompt

package.json

@@ -36,5 +36,11 @@
     "typescript": "6.0.2",
     "ultracite": "7.3.2",
     "vitest": "4.1.2"
+  },
+  "dependencies": {
+    "commander": "14.0.3",
+    "picocolors": "1.1.1",
+    "yaml": "2.8.3",
+    "zod": "4.3.6"
   }
 }

src/__fixtures__/codex-output-malformed.jsonl

@@ -0,0 +1,3 @@
+{"type": "message", "role": "assistant", "content": "Starting review..."}
+{this is not valid json}
+{"type": "message", "role": "assistant", "content": "Here are my findings: some unstructured text"}

src/__fixtures__/codex-output-valid.jsonl

@@ -0,0 +1,4 @@
+{"type": "message", "role": "assistant", "content": "レビューを開始します。"}
+{"type": "command_execution", "command": "gh issue view 3 --repo nekochans/planloop", "exit_code": 0}
+{"type": "mcp_tool_call", "tool": "context7_query", "input": {"query": "commander.js"}}
+{"type": "message", "role": "assistant", "content": "{\"findings\":[{\"id\":\"finding-1\",\"summary\":\"API endpoint path mismatch\",\"detail\":\"The plan references /api/v2/users but the spec defines /api/v1/users.\",\"severity\":\"high\",\"category\":\"correctness\"},{\"id\":\"finding-2\",\"summary\":\"Missing error handling\",\"detail\":\"Network timeout scenarios are not covered.\",\"severity\":\"medium\",\"category\":\"spec_mismatch\"}]}"}

src/__fixtures__/sample-config.ts

@@ -0,0 +1,57 @@
+import type { PlanloopConfig } from "../types/index.js";
+
+type DeepPartial<T> = {
+  [K in keyof T]?: T[K] extends Array<infer _U>
+    ? T[K]
+    : T[K] extends object
+      ? DeepPartial<T[K]>
+      : T[K];
+};
+
+const defaults: PlanloopConfig = {
+  version: 1,
+  paths: {
+    reviewDir: "design-docs-for-ai",
+    runDir: ".planloop/runs",
+  },
+  policy: {
+    requireHumanOnFirstRound: true,
+    requireHumanOnNewHighSeverity: true,
+    maxRounds: 8,
+    stagnationRounds: 2,
+    blockingCategories: [
+      "correctness",
+      "spec_mismatch",
+      "missing_acceptance_criteria",
+      "migration_risk",
+    ],
+    autoWaiveCategories: ["speculative_future", "unnecessary_fallback"],
+  },
+  review: {
+    perspectives: [
+      "correctness: 実装計画の内容が要件と一致しているか",
+      "spec_mismatch: 仕様との不一致がないか",
+      "missing_acceptance_criteria: 受け入れ基準の漏れがないか",
+      "migration_risk: マイグレーションリスクがないか",
+      "security: セキュリティ上の懸念がないか",
+      "performance: パフォーマンス上の懸念がないか",
+    ],
+  },
+  engines: {
+    claude: {
+      mode: "inherited",
+    },
+  },
+};
+
+export const createSampleConfig = (
+  overrides: DeepPartial<PlanloopConfig> = {}
+): PlanloopConfig => ({
+  version: 1,
+  paths: { ...defaults.paths, ...overrides.paths },
+  policy: { ...defaults.policy, ...overrides.policy },
+  review: { ...defaults.review, ...overrides.review },
+  engines: {
+    claude: { ...defaults.engines.claude, ...overrides.engines?.claude },
+  },
+});

src/__fixtures__/sample-findings.ts

@@ -0,0 +1,48 @@
+import type { Finding, RawFinding } from "../types/index.js";
+
+export const createRawFinding = (
+  overrides: Partial<RawFinding> = {}
+): RawFinding => ({
+  id: "finding-1",
+  summary: "Test finding summary",
+  detail: "Test finding detail",
+  severity: "high",
+  category: "correctness",
+  ...overrides,
+});
+
+export const createFinding = (overrides: Partial<Finding> = {}): Finding => ({
+  id: "finding-1",
+  summary: "Test finding summary",
+  detail: "Test finding detail",
+  severity: "high",
+  category: "correctness",
+  fingerprint: "abc123",
+  ...overrides,
+});
+
+export const sampleFindings: RawFinding[] = [
+  createRawFinding({
+    id: "finding-1",
+    summary: "API endpoint path mismatch",
+    detail:
+      "The plan references /api/v2/users but the spec defines /api/v1/users.",
+    severity: "high",
+    category: "correctness",
+  }),
+  createRawFinding({
+    id: "finding-2",
+    summary: "Missing error handling for network timeout",
+    detail:
+      "The error handling strategy doesn't cover network timeout scenarios.",
+    severity: "medium",
+    category: "spec_mismatch",
+  }),
+  createRawFinding({
+    id: "finding-3",
+    summary: "Consider adding pagination support",
+    detail: "Consider adding pagination support for future scaling needs.",
+    severity: "low",
+    category: "speculative_future",
+  }),
+];

src/__fixtures__/sample-plan.md

@@ -0,0 +1,15 @@
+# サンプル実装計画
+
+## 概要
+
+このドキュメントはテスト用のサンプル実装計画です。
+
+## 実装内容
+
+1. APIエンドポイント `/api/v1/users` の実装
+2. エラーハンドリングの追加
+3. テストコードの作成
+
+## 関連Issue
+
+https://github.com/nekochans/planloop/issues/3

src/__fixtures__/sample-prompt.md

@@ -0,0 +1,11 @@
+# サンプルプロンプト
+
+## 要件
+
+ユーザー管理APIの実装計画を作成してください。
+
+## 制約
+
+- REST APIとして実装
+- 認証にはJWTを使用
+- エラーレスポンスはRFC 7807準拠

src/adapters/claude-cli.test.ts

@@ -0,0 +1,34 @@
+import { describe, expect, it } from "vitest";
+import { extractRevisionResult } from "./claude-cli.js";
+
+describe("extractRevisionResult", () => {
+  it("should parse result from stream-json output", () => {
+    const output = `{"type":"message","role":"assistant","content":"Analyzing..."}
+{"type":"tool_use","tool":"Read","path":"plan.md"}
+{"type":"result","result":"{\\"reflectedFindings\\":[\\"finding-1\\",\\"finding-2\\"],\\"summary\\":\\"APIパスを修正しました\\"}"}`;
+
+    const result = extractRevisionResult(output);
+    expect(result.reflectedFindings).toEqual(["finding-1", "finding-2"]);
+    expect(result.summary).toBe("APIパスを修正しました");
+  });
+
+  it("should parse direct JSON result", () => {
+    const output = `{"reflectedFindings":["finding-1"],"summary":"修正完了"}`;
+    const result = extractRevisionResult(output);
+    expect(result.reflectedFindings).toEqual(["finding-1"]);
+    expect(result.summary).toBe("修正完了");
+  });
+
+  it("should return empty result for unparseable output", () => {
+    const output = "Some non-JSON text\nAnother line";
+    const result = extractRevisionResult(output);
+    expect(result.reflectedFindings).toEqual([]);
+    expect(result.summary).toBe("");
+  });
+
+  it("should handle empty output", () => {
+    const result = extractRevisionResult("");
+    expect(result.reflectedFindings).toEqual([]);
+    expect(result.summary).toBe("");
+  });
+});