Add playback speed control with pitch correction#123
Open
carterprince wants to merge 3 commits into
Open
Conversation
Author
|
With gapless playback enabled, the seek bar would behave erratically after a track transition. I pushed a fix that resolves this by resetting the pipeline's timing when a new song starts. While this technically introduces a discontinuity, the impact should be imperceptible. On my machine, the entire asynchronous seek operation completes in about 1-2ms, since the next track is already loaded and prerolled. This seems like the best trade-off but I'm definitely open to any suggestions/feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds playback speed control (0.5x to 2.0x) with optional pitch correction.
Features:
Screenshot:
I'd be happy to make any requested changes.