Skip to content

779: adds editable title to OrganisationDetails#783

Open
DarrellRoberts wants to merge 3 commits into
developfrom
darrell/feat/edit-ngo-name
Open

779: adds editable title to OrganisationDetails#783
DarrellRoberts wants to merge 3 commits into
developfrom
darrell/feat/edit-ngo-name

Conversation

@DarrellRoberts

@DarrellRoberts DarrellRoberts commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

Adds title to agent's OrganisationDetails with EditableField

Related Issues

Closes #779

Changes

  • Adds title to organisationDetailsSchema
  • Add title to OrganisationDetailsEdit
  • Add title to OrganisationDetailsDisplay
  • Add title to updateOrganization mutation func

Screenshots / Demos

image

Checklist

  • WITHIN THE SCOPE OF AN ISSUE; No unnecessary files included
  • Tests added/updated
  • Documentation updated
  • CI passes

@DarrellRoberts DarrellRoberts self-assigned this Jul 9, 2026
@need4deed need4deed requested a review from nadavosa July 13, 2026 09:23

@nadavosa nadavosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, clean, well-scoped PR — mirrors the existing pattern for every other field in this form (Controller + EditableField, same display/edit split, same i18n key structure). Nothing structurally off.

Good catch, not a bug: the diff removes the old OrganizationDetailsPatch local type in useUpdateOrganizationDetails.ts, which existed specifically because addressStreet/addressPostcode weren't yet in the SDK's ApiAgentPatch. Checked the SDK (need4deed-org/sdk/src/types/api/agent.ts) — ApiAgentPatch now includes title, about, website, addressStreet, and addressPostcode, so switching to it directly is legitimate cleanup of now-obsolete tech debt, not a regression.

Worth confirming (not a confirmed bug): the SDK's ApiAgentTitleConflict type documents a unique-title constraint enforced on agent creation, returning a distinctly-shaped { conflict: "title", agentId } 409. The doc comment scopes it to CREATE specifically, so it likely doesn't apply to this edit flow — but worth a quick check with the be side that editing an existing org's title to match another org's name fails with a normal validation message rather than an unhandled/oddly-shaped error, since no special handling for that case was added here.

Minor: no tests added, but that's consistent with the rest of this codebase's convention for form fields like this — not a real ding.

@DarrellRoberts

DarrellRoberts commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator Author

thanks @nadavosa , I tried editing the agent title on the be with an existing agent title and got a 500 server error. I wasn't able to confirm it was a validation error as I couldn't read the terminal (no longer possible on local be to create an admin account)

Nonetheless it still blocks the user from editing an agent's title to one that already exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: allow editing NGO/organization name, like volunteer and opportunity names

3 participants