Skip to content

NavigationBar Overlap Bug#782

Open
polomontague wants to merge 2 commits into
need4deed-org:developfrom
polomontague:polo/sidebar-overlap
Open

NavigationBar Overlap Bug#782
polomontague wants to merge 2 commits into
need4deed-org:developfrom
polomontague:polo/sidebar-overlap

Conversation

@polomontague

Copy link
Copy Markdown
Contributor

Description

NavigationBar is now a sticky sidebar on desktop so that is stays above the footer.
On mobile I have made it a position fixed footer behind the page footer.

Related Issues

Closes #666 (mandatory if applicable)

Changes

  • Bullet list of meaningful changes (optional)

Screenshots / Demos

If UI-related, add before/after or GIFs.

Checklist

  • WITHIN THE SCOPE OF AN ISSUE; No unnecessary files included
  • Tests added/updated
  • Documentation updated
  • CI passes

@ivannissimrch ivannissimrch self-requested a review July 9, 2026 10:30

@ivannissimrch ivannissimrch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work; this fixes the footer overlap One thing I noticed while testing: after scrolling, a gap opens up between the header and the table container.

Screencast.from.2026-07-08.21-52-32.mp4

@polomontague

Copy link
Copy Markdown
Contributor Author

Nice work; this fixes the footer overlap One thing I noticed while testing: after scrolling, a gap opens up between the header and the table container.

Screencast.from.2026-07-08.21-52-32.mp4

That’s weird. That didn’t happen when I tested it also in Chrome.

@nadavosa nadavosa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction here (desktop: `fixed` → `sticky`, mobile keeps `fixed` explicitly) makes sense for an overlap bug like this.

Two things worth confirming before merge, since this is a purely visual fix with no tests and no before/after screenshots attached (the PR template asks for them for UI changes):

  • `position: sticky` only resolves the overlap correctly if the parent container's height is properly bounded before the footer — that's not verifiable from the diff alone. Could you confirm in a live browser check on a short page, a long/scrolled page, and mobile?
  • The `z-index: 1 → 0` change on `BarContainer` — worth double-checking it doesn't cause the bar to render behind some other stacked element that it used to sit above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: dashboard sidebar overlaps the footer when scrolling to the bottom

3 participants