🐛 fix: sort by newest order focoordinator comments (#738)#765
Merged
need4deed merged 2 commits intoJul 13, 2026
Conversation
ivannissimrch
left a comment
ivannissimrch
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the logic and verified the sort with several cases already-sorted, random,
oldest-first, same-day, equal timestamps, it always returns newest-first regardless of the order the backend sends.
nadavosa
reviewed
Jul 13, 2026
nadavosa
left a comment
nadavosa
left a comment
Collaborator
There was a problem hiding this comment.
Clean, minimal fix — replacing `.reverse()` with a sort by `timestamp` (a valid typed field on `TimedText`) is correct and well-scoped to the bug described.
One note: no CI check has run on this PR yet (`gh pr checks` returns nothing). Worth confirming `yarn lint`/`yarn typecheck` locally before merging since there's no automated signal yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed bug where new comments were stacked between older comments (specifically for users with Coordinator roles), by replacing .reverse() with a sort by timestamp. This should ensure newest comments always appear at the top regardless of the order sent by the backend.
Related Issues
Closes #738
Changes
Screenshots
Checklist