Dockerfile#5
Merged
Merged
Conversation
Collaborator
is not working |
complete_mapped_file split on ':' first, which consumed the drive-letter colon (C:\...) as the host/instance separator on Windows and never reached the host-path branch. Peel the drive off first with os.path.splitdrive, matching MappedFile.parse, so segment-0 completion works on Windows. Fixes the failing test_initial_host_path test on Python 3.10-3.13 on windows-latest.
ARG B=${A} stored the literal "${A}" instead of expanding against
previously declared ARGs and ENVs, so an ENV/RUN that referenced $B
saw "${A}" verbatim. Match Docker BuildKit semantics by running the
default through ctx.substitute at execute time.
Also adds a regression test for the reported pattern:
ARG APP_HOME=/opt/streamforge
ENV APP_HOME=${APP_HOME}
which already worked but was uncovered, plus the broken-until-now
ARG-default-referencing-earlier-ARG case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and improvements to the CLI, focusing on enhanced Dockerfile build support, improved file management, and expanded operation monitoring. The most significant changes are the addition of a
buildcommand for Dockerfile-based image creation, a newfile lscommand for listing uploaded files with local source tracking, and newoperationcommands for managing and monitoring background tasks. Documentation and CLI help texts have been updated to reflect these enhancements.New Features and Major Additions
Dockerfile Build Command
buildcommand (contree build) that builds images from Dockerfiles, supports common Dockerfile directives, layer caching, build arguments, tagging, and cache bypassing. Also includes parser, argument handling, and error management. [1] [2] [3] [4]File Management Enhancements
file lscommand to list uploaded files, join with the local cache to show the file's source (host path or URL), and support filtering by time, limiting output, and quiet mode for scripting. [1] [2] [3] [4] [5]Operation Monitoring and Management
operation(op) commands:op ls,op show, andop cancel, allowing batch inspection and cancellation of background operations. Updated docs and CLI help to reflect new patterns for managing detached runs. [1] [2] [3] [4] [5]Improvements and Refactoring
Image Listing Output
created_atandtagfields, and improve compatibility with the formatter.Documentation and Help Updates
These changes significantly enhance the usability and capabilities of the CLI, especially for workflows involving Dockerfile-based builds, file tracking, and batch operation management.