fix(lockup): add test of unlocking schedule with termination#188
Closed
telezhnaya wants to merge 1 commit into
Closed
fix(lockup): add test of unlocking schedule with termination#188telezhnaya wants to merge 1 commit into
telezhnaya wants to merge 1 commit into
Conversation
telezhnaya
requested review from
bowenwang1996 and
evgenykuzyakov
as code owners
November 11, 2021 17:00
Contributor
Author
|
I guess it's better to mention the doc in the comments |
frol
reviewed
Nov 20, 2021
Contributor
There was a problem hiding this comment.
@telezhnaya I find this test to be quite hard to follow due to "magical consts"
Member
|
Standard wise, it will be test(lockup) if there is no actual fix in the PR but only tests added. |
Contributor
Author
|
Addressed all the review comments in #191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187
I also need to rebuild the binary again; I'll do that after we review the test.
I decided to check all that we wanted on one contract instead of 2, it looks simpler for me and it checks the same stuff.