Fix/contig variants check if ins - #259
Merged
joshfactorial merged 1 commit intoApr 6, 2026
Merged
Conversation
Insertion.contains() expects an int (a reference position), but check_if_ins was passing the full variant object. This caused the method to always return None, silently failing to detect variants overlapping an insertion span. Adds regression tests in tests/test_variants/test_check_if_ins.py. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
joshfactorial
changed the base branch from
develop
to
fix/contig-variants-remove-variant
April 6, 2026 00:35
joshfactorial
merged commit Apr 6, 2026
0be5cfd
into
fix/contig-variants-remove-variant
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a small bug in contig var and added tests, composed with help from Claude.