Skip to content

feat(validation): persist review evidence and routing#91

Merged
ncolesummers merged 2 commits into
mainfrom
codex/49-validation-evidence
Jul 21, 2026
Merged

feat(validation): persist review evidence and routing#91
ncolesummers merged 2 commits into
mainfrom
codex/49-validation-evidence

Conversation

@ncolesummers

@ncolesummers ncolesummers commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • add loopworks.screenshot_evidence.v1 and typed validation-review result contracts
  • persist validation-owned responsive captures with schema migration and existing-run backfill
  • enforce passing, fresh, cross-artifact-bound validation before code review
  • apply commit, development, and test-writing routes only through the root transition boundary
  • cover replay, concurrency, retry budgets, telemetry redaction, PNG integrity, and viewport completeness

Why

Issue #49 needs a deterministic evidence boundary before an LLM reviewer can run. This base slice establishes the durable contracts, validation capture lane, and root-controlled transition policy without yet adding the Eve sibling runtime.

Stack

  1. This PR: durable evidence, persistence, and routing core
  2. feat(agent): add validation review sibling #92 — Eve reviewer, tools, and eval
  3. docs(architecture): propose validation review cycles #93 — ADR and architecture documentation

Merge in order. Later PRs use the preceding branch as their base and can be retargeted to main after each dependency merges.

Validation

  • bun run validate
  • bun run build
  • bun run test:e2e:validation-evidence — 66 responsive/browser/a11y cases across 390x844, 1280x832, and 1440x960

Part of #49.

Co-authored with OpenAI Codex (GPT-5).

Add typed validation-review results, responsive screenshot evidence, root-controlled cyclical transitions, migration backfill, and deterministic regression coverage.

Co-Authored-By: OpenAI Codex GPT-5 <noreply@openai.com>
@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
loopworks Ready Ready Preview, Comment Jul 14, 2026 5:53pm

Request Review

Infer the fixture return type so the validation evidence slice does not depend on the later Eve reviewer context module.

Co-Authored-By: OpenAI Codex GPT-5 <noreply@openai.com>
@ncolesummers
ncolesummers marked this pull request as ready for review July 16, 2026 15:27
Copilot AI review requested due to automatic review settings July 16, 2026 15:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ncolesummers
ncolesummers merged commit 316630e into main Jul 21, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Loopworks Backlog Jul 21, 2026
@ncolesummers
ncolesummers deleted the codex/49-validation-evidence branch July 21, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants