This repository was archived by the owner on Sep 12, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 132
label: Rewrite javadoc in English #632
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,15 +11,12 @@ | |
| import java.util.Set; | ||
|
|
||
| /** | ||
| * 프로젝트에 붙일 수 있는 라벨 | ||
| * A label to be attached to a project | ||
| */ | ||
| @Entity | ||
| @Table(uniqueConstraints = @UniqueConstraint(columnNames = {"category", "name"})) | ||
| public class Label extends Model implements ResourceConvertible { | ||
|
|
||
| /** | ||
| * | ||
| */ | ||
| private static final long serialVersionUID = -35487506476718498L; | ||
| public static final Finder<Long, Label> find = new Finder<>(Long.class, Label.class); | ||
|
|
||
|
|
@@ -36,9 +33,10 @@ public class Label extends Model implements ResourceConvertible { | |
| public Set<Project> projects; | ||
|
|
||
| /** | ||
| * 주어진 {@code category}와 {@code name}으로 라벨를 생성한다. | ||
| * @param category 이 라벨가 속한 분류 | ||
| * @param name 이 라벨의 이름 | ||
| * Construct a label by the given {@code name} and {@code category}. | ||
| * | ||
| * @param category the category to which this label belongs | ||
| * @param name the name of this label | ||
| */ | ||
| public Label(String category, String name) { | ||
| if (category == null) { | ||
|
|
@@ -49,9 +47,9 @@ public Label(String category, String name) { | |
| } | ||
|
|
||
| /** | ||
| * 라벨를 삭제한다. | ||
| * Delete this label. | ||
| * | ||
| * 모든 프로젝트에서 이 라벨를 제거한 뒤, 라벨를 삭제한다. | ||
| * Remove this label from every project and delete it. | ||
| */ | ||
| @Override | ||
| public void delete() { | ||
|
|
@@ -64,23 +62,23 @@ public void delete() { | |
|
|
||
|
|
||
| /** | ||
| * 라벨를 문자열로 변환하여 반환한다. | ||
| * Returns a string representation of this label. | ||
| * | ||
| * {@link Label#category}와 {@link Label#name}을 " - "로 연결한 문자열을 반환한다. | ||
| * | ||
| * @return "{@link Label#category} - {@link Label#name}" 형식의 문자열 | ||
| * @return a string concatenated {@link Label#category}, "-" and {@link Label#name} | ||
| * e.g. "os - linux" | ||
| */ | ||
| @Override | ||
| public String toString() { | ||
| return category + " - " + name; | ||
| } | ||
|
|
||
| /** | ||
| * 라벨를 {@link Resource} 형식으로 반환한다. | ||
| * Returns a {@link Resource} representation of this label. | ||
| * | ||
| * when: 이 라벨에 대해 접근권한이 있는지 검사하기 위해 {@link utils.AccessControl}에서 사용한다. | ||
| * {@link utils.AccessControl}.may use this method to check if an user has | ||
| * a permission to access this label. | ||
| * | ||
| * @return {@link Resource}로서의 라벨 | ||
| * @return a {@link Resource} representation of this label | ||
| */ | ||
| @Override | ||
| public Resource asResource() { | ||
|
|
@@ -97,6 +95,11 @@ public ResourceType getType() { | |
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Remove this label from a project. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removes~
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 넵 알겠습니다. |
||
| * | ||
| * @param project the project from which this label is removed | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM |
||
| */ | ||
| public void delete(Project project) { | ||
| this.projects.remove(project); | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지난번에 리뷰한 내용이 반영이 안돼어있습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 고치겠습니다.