fix(orch): review the implementer's actual checkout, not a pasted diff#65
Merged
Conversation
The adversarial reviewer was given a CLEAN checkout off base with the entire diff inlined into its launch prompt as text. That one choice was the common root of three failures: the prompt bloated past tmux's command-length cap (reviewers died 'command too long' and retried, orphaning multi-GB checkouts until the box hit 100% disk); the reviewer couldn't build or test the real change; and any fix it committed landed on a throwaway branch that shipped nowhere (a reviewer's compiled-run follow-up was lost this way). The reviewer now inherits the implementer's actual checkout (depends_on the terminal implementer, so no concurrent writer) and reads the change with git diff — the diff leaves the prompt entirely. A fix it commits lands on the branch the PR ships from. submit_review re-pins the verdict to the diff as it stands at submit, so a reviewer's own fix doesn't move the fingerprint and bounce its approval into an endless re-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The adversarial reviewer was given a clean checkout off base with the entire diff inlined into its launch prompt as text. That one choice was the common root of three failures we hit:
command too long, retried, and orphaned multi-GB checkouts until the box hit 100% disk (today's whole cascade).The reviewer now inherits the implementer's actual checkout (
depends_onthe terminal implementer, so no concurrent writer) and reads the change withgit diff— the diff leaves the prompt entirely. A fix it commits lands on the branch the PR ships from.submit_reviewre-pins the verdict to the diff as it stands at submit, so a reviewer's own fix doesn't move the fingerprint and bounce its approval into an endless re-review.Tests: extended
TestReviewGate_OnHoldsAndSpawnsAdversary(inherits checkout, no diff in prompt) + newTestReviewGate_ReviewerFixShipsWithApproval.