Ensure controller is not destroyed before setting contextRoute#16
Open
cyk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading to Ember.js 2.13x, I'm getting "calling set on destroyed object" errors when running my acceptance tests. It's not always the same test and is thrown when route-alias initializer reopens and sets
routeContexton the controller.Unfortunately, I have not yet been able to write an isolated test case to reproduce, and the code base manifesting is private. What I do know is that adding a simple check, seems to resolve this particular issue. This PR introduces that check.
Other notes that may be helpful:
link-towhere the target route is an alias for a dynamic route