Fix nasa#229, Check return values for CFE_SB_Subscribe in TO_LAB_init()#230
Merged
myc-yang merged 1 commit intoJun 15, 2026
Merged
Conversation
myc-yang
force-pushed
the
229-ignored-return-value-cfe-sb-subscribe
branch
from
742ca38 to
1b1a1e6
Compare
jphickey
reviewed
May 22, 2026
jphickey
left a comment
jphickey
left a comment
Contributor
There was a problem hiding this comment.
Similar to my comment in the DS change here: nasa/DS#147 (review)
I don't like having if/else branches nested like this, as it increases the cyclic complexity of the functions. I would rather this be divided into subroutines or otherwise simplified to avoid deeply-nested if/else branches.
That being said, I can accept the argument that this is a "lab" app.
myc-yang
force-pushed
the
229-ignored-return-value-cfe-sb-subscribe
branch
from
1b1a1e6 to
c7efdfa
Compare
jphickey
reviewed
Jun 2, 2026
myc-yang
force-pushed
the
229-ignored-return-value-cfe-sb-subscribe
branch
4 times, most recently
from
262dddf to
d8fcc63
Compare
jphickey
reviewed
Jun 11, 2026
myc-yang
force-pushed
the
229-ignored-return-value-cfe-sb-subscribe
branch
from
d8fcc63 to
3363d43
Compare
…_MID and TO_LAB_SEND_HK_MID in TO_LAB_init() in fsw/src/to_lab_app.c
myc-yang
force-pushed
the
229-ignored-return-value-cfe-sb-subscribe
branch
from
3363d43 to
51cf370
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
When subscribing to TO_LAB CMD and Send HK CMD, we are ignoring the return value. This is captured in #229.
Testing performed
I did not run any unit tests because there were none written for TO_LAB using UT_assert.
Expected behavior changes
TO_LAB_CMD_MIDorTO_LAB_SEND_HK_MIDSystem(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Michael Yang NASA/GSFC