Fix nasa/cFS#952, Clamp encoded output size to CFE_MISSION_SB_MAX_SB_MSG_SIZE#220
Open
heathdutton wants to merge 1 commit into
Open
Fix nasa/cFS#952, Clamp encoded output size to CFE_MISSION_SB_MAX_SB_MSG_SIZE#220heathdutton wants to merge 1 commit into
heathdutton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
TO_LAB_EncodeOutputMessageuses the CCSDS-derived size as the socket send length. A crafted Length field can causeOS_SocketSendToto read past the SB buffer. Clamps the size toCFE_MISSION_SB_MAX_SB_MSG_SIZE, the upper bound of any SB allocation. This is the reporter's stated minimum remediation.Testing performed
Compiled under the project's CMake flags with
-Werror(no new warnings) andclang-format --dry-run --Werroragainst the repo.clang-format(clean).apps/to_labhas no UT scaffolding, so no test update was possible.Expected behavior changes
Well-formed telemetry unaffected. A malformed message with an inflated Length field is now transmitted at the clamped size instead of reading adjacent heap memory. No API change.
System(s) tested on
Additional context
Partial remediation. Full elimination of the over-read requires SB-layer size tracking, which is the scope of nasa/cFS#953. The EDS variant
to_lab_eds_encode.chas a related code path already bounded byNetworkBufferand is left for a separate change to keep scope tight.Contributor Info
Heath Dutton, Personal