Spec revision for shift operations for numeric values#1000
Merged
Conversation
21 tasks
Collaborator
|
Thanks for making this PR. Can you please move the changes to the User's Guide out of this PR and onto another branch? For this PR, I need to review and approve just the spec changes. The User's Guide changes require the updated implementation, or the examples won't compile. |
abh80
force-pushed
the
spec/shift-op
branch
2 times, most recently
from
288cd38 to
d7f3be1
Compare
Contributor
Author
|
Thanks for the review, I have moved the commit and rebuilt the specs |
bocchino
approved these changes
May 14, 2026
Collaborator
bocchino
left a comment
bocchino
left a comment
There was a problem hiding this comment.
This looks good! I made a few changes to the spec. Can you revise the implementation PR so it matches the spec? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec revision for #995