Skip to content

Handle missing implementation when resampling #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cnativid wants to merge 4 commits into from
Closed

Handle missing implementation when resampling #76

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6e5847
if no implementation is found during resample, don't try to assign on…
cnativid Apr 6, 2026
326df6c
add TODO to resample to add option to rebuild implementation
cnativid Apr 6, 2026
6eed2ee
add TODO to resample to add option to rebuild implementation
cnativid Apr 6, 2026
b8d5f8a
Merge branch 'handle-no-implementation' of github.com:cnativid/condor…
cnativid Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/condor/contrib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,11 @@ def resample(self, dt, include_output=True, include_events=True, max_deg=3):
return self

new_self = model.__new__(model)
new_self.implementation = self.implementation
# TODO: add option to rebuild the implemention
if getattr(self, "implementation", False):

@ixjlyons ixjlyons Apr 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try hasattr(self, "implementation") for just checking whether or not the attribute exists

new_self.implementation = self.implementation
else: # override include_output if implementation is not found
include_output = False

@ixjlyons ixjlyons Apr 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we aren't (yet) automatically constructing the implementation, this should probably emit a warning (only if the user set include_output=True).

new_self._original_instance = original_instance
new_self.bind_field(self.parameter)
new_self.input_kwargs = self.input_kwargs
Expand Down
Loading