Skip to content

Updates the client to work using Refresh Tokens instead of clientId and Secret#74

Open
dakota002 wants to merge 2 commits into
nasa-gcn:mainfrom
dakota002:RefreshTokenUpdate
Open

Updates the client to work using Refresh Tokens instead of clientId and Secret#74
dakota002 wants to merge 2 commits into
nasa-gcn:mainfrom
dakota002:RefreshTokenUpdate

Conversation

@dakota002

Copy link
Copy Markdown
Contributor

This ties into the update for nasa-gcn/gcn.nasa.gov#3095

@dakota002
dakota002 requested a review from lpsinger May 9, 2025 20:44
@codecov

codecov Bot commented May 9, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.80%. Comparing base (7791c72) to head (0371d6c).
⚠️ Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
src/gcn_kafka/core.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   76.10%   80.80%   +4.69%     
==========================================
  Files           7        7              
  Lines         113      125      +12     
==========================================
+ Hits           86      101      +15     
+ Misses         27       24       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dakota002

Copy link
Copy Markdown
Contributor Author

Fixing the package issues now

Comment thread src/gcn_kafka/oidc.py Outdated
@dakota002

Copy link
Copy Markdown
Contributor Author

The tests need to be fixed still

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.5.0 to 5.6.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@8d9ed9a...a26af69)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 5.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

[pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.11.6 → v0.11.7](astral-sh/ruff-pre-commit@v0.11.6...v0.11.7)

[pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.11.7 → v0.11.8](astral-sh/ruff-pre-commit@v0.11.7...v0.11.8)

Updates the client to work using Refresh Tokens instead of clientId and Secret

Add missing package

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Fix positional args, Fix imports, add OAuthClient

Fix the JWT package use to point to pyjwt, fix token response

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Trying to fix tests

Changes to tests to reflect new updates

Update tests

Update tests

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Rebase fix
@dakota002
dakota002 force-pushed the RefreshTokenUpdate branch from 71ad1b9 to ea027d6 Compare May 19, 2025 18:28
@dakota002
dakota002 requested a review from lpsinger May 19, 2025 18:32
@dakota002 dakota002 linked an issue May 22, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for refresh tokens

2 participants