Skip to content

chore: add trailing-whitespace precommit - #3826

Merged
FBruzzesi merged 2 commits into
narwhals-dev:mainfrom
EdAbati:chore/whitespace-precommit
Jul 31, 2026
Merged

chore: add trailing-whitespace precommit#3826
FBruzzesi merged 2 commits into
narwhals-dev:mainfrom
EdAbati:chore/whitespace-precommit

Conversation

@EdAbati

@EdAbati EdAbati commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Description

I saw some PR including #3821 that has some whitespaces in the diff.
This should help removing that noise (even if Github should remove some whitespaces now in the PR review view) :)

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

AI assistance

  • No AI tools were used for this PR.
  • AI tools were used.

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

@EdAbati
EdAbati requested a review from FBruzzesi July 31, 2026 07:19

@FBruzzesi FBruzzesi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EdAbati - I also recently noticed some of those cases in #3820

@FBruzzesi
FBruzzesi merged commit a87d389 into narwhals-dev:main Jul 31, 2026
42 of 44 checks passed
@EdAbati
EdAbati deleted the chore/whitespace-precommit branch July 31, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants