docs: reuse Makefile targets in CI and simplify AGENTS.md - #3825
Merged
FBruzzesi merged 7 commits intoJul 30, 2026
Conversation
EdAbati
commented
Jul 30, 2026
| that catches missing `# pragma: no cover`): | ||
|
|
||
| ```bash | ||
| PYTEST_ADDOPTS="--numprocesses=logical" make run-ci DEPS="--extra pandas --extra dask --group core-tests --group sklearn --group plugins" CMD="pytest tests --cov=src --cov=tests --cov-fail-under=100 --runslow --durations=30 --constructors=pandas,pandas[nullable],pandas[pyarrow],pyarrow,polars[eager],polars[lazy],dask,duckdb,sqlframe" |
Collaborator
Author
There was a problem hiding this comment.
this was a bit too long for the agent IMO
EdAbati
commented
Jul 30, 2026
| - Install prek as a git hook: `uv run prek install` | ||
| - To run tests: `uv run pytest` | ||
| - To run all linting checks: `make lint` | ||
| - To run ruff formatting and linting: `make lint` |
Collaborator
Author
There was a problem hiding this comment.
technically make lint does NOT "run all linting checks" :)
EdAbati
commented
Jul 30, 2026
| .PHONY: docs-build | ||
| docs-build: ## Build the docs locally | ||
| uv run --group docs zensical build --clean | ||
| .PHONY: docs-dynamic-content |
Collaborator
Author
There was a problem hiding this comment.
to make it reusable
FBruzzesi
approved these changes
Jul 30, 2026
Co-authored-by: Francesco Bruzzesi <42817048+FBruzzesi@users.noreply.github.com>
Co-authored-by: Francesco Bruzzesi <42817048+FBruzzesi@users.noreply.github.com>
FBruzzesi
merged commit Jul 30, 2026
5735064
into
narwhals-dev:docs/AGENTS-md
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We can move some commands to the Makefile to make it easier for human and agents to run them
see in-line comments for more details :)
This PR is to your #3821 branch @FBruzzesi
What type of PR is this? (check all applicable)
Related issues
AI assistance
Checklist
Code follows style guide (ruff)
Tests added
Documented the changes
If this is your first PR to narwhals, attach a screenshot of
pytestpassing locally (not CI):