feat: Support plugin native objects in is_into_* - #3754
Merged
Conversation
FBruzzesi
commented
Jul 5, 2026
Comment on lines
+113
to
+131
| def is_native_dataframe(native_object: Any) -> bool: | ||
| """Check whether an installed plugin converts `native_object` to an eager DataFrame.""" | ||
| from narwhals._utils import Version, is_compliant_dataframe | ||
|
|
||
| return is_compliant_dataframe(from_native(native_object, Version.MAIN)) | ||
|
|
||
|
|
||
| def is_native_lazyframe(native_object: Any) -> bool: | ||
| """Check whether an installed plugin converts `native_object` to a LazyFrame.""" | ||
| from narwhals._utils import Version, is_compliant_lazyframe | ||
|
|
||
| return is_compliant_lazyframe(from_native(native_object, Version.MAIN)) | ||
|
|
||
|
|
||
| def is_native_series(native_object: Any) -> bool: | ||
| """Check whether an installed plugin converts `native_object` to a Series.""" | ||
| from narwhals._utils import Version, is_compliant_series | ||
|
|
||
| return is_compliant_series(from_native(native_object, Version.MAIN)) |
Member
Author
There was a problem hiding this comment.
Whether an object is eager or lazy is only knowable from the compliant object a plugin produces, so this calls the plugin's from_native and inspects the result.
FBruzzesi
commented
Jul 5, 2026
Member
Author
There was a problem hiding this comment.
Mocking everything I can here, #3753 adds much more features in test-plugin that can be used here
MarcoGorelli
approved these changes
Jul 7, 2026
| assert not is_into_lazyframe(data) | ||
| assert not v1_is_into_lazyframe(data) | ||
| assert not v2_is_into_lazyframe(data) | ||
| # If `test_plugin` is installed, a plain `dict` is convertible to a LazyFrame. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3714
What type of PR is this? (check all applicable)