Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Bundle create API so that
ServiceRequest.orderDetailis handled as an elaboration of the requested service, rather than as an extension of the panel codeCurrent behavior
When a Bundle is posted, the tests listed in
ServiceRequest.orderDetailare currently added to the panel specified in code. This is semantically incorrect becauseorderDetailshould describe the requested tests for theServiceRequest, not extend the panel itself. As a result, partial panel subsets are not rejected and the default panel code path is not validated as expected.Desired behavior
ServiceRequest.orderDetail should be interpreted according to the selected code:
orderDetailis omitted, the request should defer to the panel and create all tests defined in that panelorderDetailis present, it must include all tests in the panel; additional tests are allowed.orderDetail, the request should be rejected with 400 Bad Request and anOperationOutcomeorderDetailshould define the exact requested tests and no panel validation should be appliedorderDetailis omitted, the request should be rejected with 400 Bad Request and anOperationOutcome--
I confirm that I have thoroughly tested this Pull Request and that the code
adheres to the PEP 8 and Plone 5 Python style guide standards.