Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes misleading FHIR
basedOnreferences fromDiagnosticReportandObservationresources when the sample/analysis request was created directly inside SENAITE.Current behavior
SENAITE-generated samples still emit
basedOnreferences in diagnostic reports and observations, which makes them appear to originate from an externalServiceRequesteven when they were created internallyDesired behavior
basedOnshould only be included when the sample is linked to an externally originated FHIRServiceRequest. For samples created internally in SENAITE,basedOnshould be omitted from bothDiagnosticReportandObservation--
I confirm that I have thoroughly tested this Pull Request and that the code
adheres to the PEP 8 and Plone 5 Python style guide standards.