Skip to content

Fixed how some gridutils functions treat the logger#1996

Merged
abhisrkckl merged 6 commits into
nanograv:masterfrom
dlakaplan:gridlog
May 28, 2026
Merged

Fixed how some gridutils functions treat the logger#1996
abhisrkckl merged 6 commits into
nanograv:masterfrom
dlakaplan:gridlog

Conversation

@dlakaplan
Copy link
Copy Markdown
Contributor

Some of the functions for doing gridded fits did not respect the global logger settings. This is better now, although I am still seeing some weird behavior from the clock module.

@dlakaplan dlakaplan added awaiting review This PR needs someone to review it so it can be merged minor A minor PR that doesn't need a lot of thought labels May 22, 2026
@dlakaplan
Copy link
Copy Markdown
Contributor Author

Also added a few annoying messages to "onlyonce" list

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.34%. Comparing base (036a0bc) to head (8e414f9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1996   +/-   ##
=======================================
  Coverage   70.34%   70.34%           
=======================================
  Files         109      109           
  Lines       25652    25652           
  Branches     4081     4081           
=======================================
  Hits        18044    18044           
  Misses       6453     6453           
  Partials     1155     1155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abhisrkckl
Copy link
Copy Markdown
Contributor

This looks fine. I will merge this if ready.

@dlakaplan
Copy link
Copy Markdown
Contributor Author

I think it is now (or will be after the checks finish). Still don't fully understand all of the subtleties here, but it is a lot better than before.

@abhisrkckl abhisrkckl merged commit dd0f455 into nanograv:master May 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review This PR needs someone to review it so it can be merged minor A minor PR that doesn't need a lot of thought

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants