Add weather example and fix reactive method body rewrites#98
Merged
Conversation
- Add comprehensive weather example exercising @SolidQuery debounce, parallel resources, widget ctor field reads, and three-deep @SolidEnvironment chains - Fix widget→state scope shift missing in @SolidQuery/@SolidEffect/@SolidState getter bodies; rewrite now applies to all reactive member bodies, not just build() - Remove over-strict validation rejecting Future queries with arrow bodies - Update documentation; remove obsolete --delete-conflicting-outputs flag from build_runner commands
Deploying solid with
|
| Latest commit: |
513a770
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8038d857.solid-4m0.pages.dev |
| Branch Preview URL: | https://t3code-5b17e317.solid-4m0.pages.dev |
When @SolidQuery reads cross-class signals via @SolidEnvironment receiver, the synthesized Record-Computed source now auto-injects the field types it names into lib output during cross-file resolution. Eliminates manual // ignore: unused_import workarounds. Includes test coverage for both imported and unimported cross-class type scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/weather/) stress-tests Solid generator on@SolidQuery(debounce:),.refresh(), per-instance resources keyed off widget constructor params, and three-level@SolidEnvironmentchains@SolidQuery,@SolidEffect, and@SolidStategetter bodies now correctly rewrite bare widget-bound field references towidget.X(same rewrite asbuild()method). Added three regression test goldensFuture<T>queries with arrow bodies; all four body shapes (=> expr,async => expr,{ return expr; },async { return expr; }) are now accepted--delete-conflicting-outputs(removed in recent build_runner versions; deletion is now implicit)examples/weather/EVALUATION.mddocuments findings, root causes, fixes, and lingering generator restrictions encountered during authoringTesting
dart run build_runner buildpasses cleanly inexamples/weather/dart analyze --fatal-infospasses inexamples/weather/dart format --set-exit-if-changed .passes inexamples/weather/@SolidQuery,@SolidEffect, and@SolidStategetter bodiesfuture_without_asyncand replaced with positive goldenquery_future_arrow_body