Add the birth certificate amendment form for MA#656
Conversation
|
@kydecker this is ready for review! I also added 3 questions/notes to the PR description. Would love to hear your thoughts 🙏 By the way the PDF uploading tool is reaaaally fucking cool, great work to everyone who contributed to that. The only issue I ran into is that it flagged a radio group as a textfield but that was easy to fix in the schema. |
|
@deammer Thank you for the contribution!! I'm busy tonight but I will take some time to review this and answer your questions tomorrow. |
kydecker
left a comment
There was a problem hiding this comment.
Thank you so much for kicking this off!
I suggested a handful of copy edits below.
In response to your questions:
the form has a weird field called "Contact information" that doesn't really make sense so I ignored it
Yup, totally fine to just exclude this. There are weird elements in some of these PDF forms.
can we make middle names optional? I didn't see a canonical way to do that but maybe I missed it.
The "missing!" highlights are a little rough around the edges right now for things like this (where a field is displayed but intentionally left blank). Don't worry about it for now.
in the exported PDF, the 2 checkboxes are misalinged (I'm using Waterfox 6.6.15). It's misaligned in a way that makes it look like the wrong box is checked...
Oh, bummer, We need to manually move those fields into the correct position. It's possible to do this with pdf-lib, and probably a feature we could build into the PDF Manager... in the meantime, you could try uploading the PDF to the BentoPDF Form Creator, repositioning the fields, and saving the updated PDF.
Finally, I filed an issue to fix the RadioGroup detection in the PDF Manager: #659
It should be a pretty easy fix if you want to bundle it with this PR, otherwise we can tackle it separately!
Thanks again!
Take Ky's suggestions Co-authored-by: Ky Decker <hi@ky.fyi>
|
@kydecker thank you for the review! I've made all the updates you requested + updated Gonna try to fix up the placement of the checkboxes on the form now. |
kydecker
left a comment
There was a problem hiding this comment.
Nice, looking good! I tested the flow and things are working well.
I have a few more content edits, and one thought about potentially removing the supporting documents step. Curious to hear your thoughts!
There was a problem hiding this comment.
This step feels kind of odd to me. As a user, it's confusing to understand. I'm tempted to say we should see if we can a) relocate the checkboxes elsewhere, or b) get rid of this step entirely and infer responses.
The court order/name change decree is required if the applicant is updating their name in addition to the gender marker. So as long as there is a new name different from the old name, this box can be checked, and we can display a notice (in the instructions, and in the guide itself) instructing them to bring their name change decree with them when filing for the updated birth certificate.
Additionally, we should probably have some sort of check to verify that the birth gender and updated gender are different. If they are the same, Massachusetts doesn't allow users to amend their birth certificate—we could display a banner informing the user about this.
For the "I am including a check or money order"... I'm not really sure why the user needs to check this manually. I guess the only reason you would not check it is if you were filing the Affidavit of Indigency along with this form? In which case, it would be more user-friendly to simply ask, "Do you need to waive fees?" If yes, we can include the Affidavit of Indigency, and if no, we let them know the costs and accepted payment methods, and automatically check the checkbox on the form.
| birthNameStep, | ||
| birthGenderStep, | ||
| dateOfBirthStep, | ||
| birthTownStep, | ||
| parentNamesStep, | ||
| // Section: Name and Sex to appear on amended birth certificate | ||
| newNameStep, | ||
| newGenderStep, | ||
| mailingAddressStep, | ||
| contactInfoStep, | ||
| // Section: Applicant affidavit | ||
| supportingDocumentsStep, | ||
| // Section: For subjects under 18 years of age | ||
| guardianAuthorizationStep, |
There was a problem hiding this comment.
| birthNameStep, | |
| birthGenderStep, | |
| dateOfBirthStep, | |
| birthTownStep, | |
| parentNamesStep, | |
| // Section: Name and Sex to appear on amended birth certificate | |
| newNameStep, | |
| newGenderStep, | |
| mailingAddressStep, | |
| contactInfoStep, | |
| // Section: Applicant affidavit | |
| supportingDocumentsStep, | |
| // Section: For subjects under 18 years of age | |
| guardianAuthorizationStep, | |
| birthGenderStep, | |
| newGenderStep, | |
| birthNameStep, | |
| newNameStep, | |
| dateOfBirthStep, | |
| birthTownStep, | |
| parentNamesStep, | |
| mailingAddressStep, | |
| contactInfoStep, | |
| // Section: Applicant affidavit | |
| supportingDocumentsStep, | |
| // Section: For subjects under 18 years of age | |
| guardianAuthorizationStep, |
Some thoughts about step ordering: can we put the gender steps and name steps next to one another, and put the gender steps first, to warn the user if they choose the same option for both?
| }, | ||
| { | ||
| name: "oldGender", | ||
| label: "Current documented gender", |
There was a problem hiding this comment.
| label: "Current documented gender", | |
| label: "Existing gender marker", |
| }, | ||
| { | ||
| name: "newGender", | ||
| label: "Desired gender", |
There was a problem hiding this comment.
| label: "Desired gender", | |
| label: "Desired gender marker", |
| title: "Parent or guardian authorization", | ||
| description: | ||
| "At least one parent or guardian must authorize this change if you are under 18 years old.", |
There was a problem hiding this comment.
| title: "Parent or guardian authorization", | |
| description: | |
| "At least one parent or guardian must authorize this change if you are under 18 years old.", | |
| title: "Parent or guardian authorization", | |
| description: | |
| "Since you are under 18 years old, at least one parent or guardian must authorize this change.", |
| label="Parent or guardian 1's full name" | ||
| name="guardianOneFullName" | ||
| size={24} | ||
| isRequired |
There was a problem hiding this comment.
| isRequired |
Ah, we actually need to remove this. We currently don't enforce fields being filled out at any point in the flow, and don't have any logic setup to handle displaying errors for required fields.
The logic is that we want people to be able to skip any fields they are uncomfortable with filling out (or unable to fill out) so that they can do it after printing.

Changes:
Notes:
I ran into a few weird things, please let me know how you'd like to proceed:
Implements #647. No genAI was used in the process 💅