feat(NPF-4641): add js preload link to bundles#696
Merged
Conversation
stas-nc
reviewed
Apr 2, 2026
| }; | ||
|
|
||
| #getSsrFragmentScriptRefsToPreload = (fragmentsContext, apps) => { | ||
| const scriptRefs = _.reduce( |
Member
There was a problem hiding this comment.
refrain from using lodash, planning to drop it.
Contributor
Author
There was a problem hiding this comment.
valid point, will remove it from the file
stas-nc
reviewed
Apr 2, 2026
Member
There was a problem hiding this comment.
maybe typescript here, looks like good chance for this file.
stas-nc
reviewed
Apr 2, 2026
| } | ||
| } | ||
|
|
||
| export = ConfigsInjector; |
Contributor
Author
There was a problem hiding this comment.
Yes, I understand. But this is due to current consumers for the classes. This module is still consumed via plain CommonJS:
const ConfigsInjector = require('./configs-injector');
new ConfigsInjector(...)This package builds with module: "commonjs", so a normal named export like export class ConfigsInjector compiles to exports.ConfigsInjector = ConfigsInjector. In that case require('./configs-injector') returns a module object, not the constructor itself.
To allow export class ConfigsInjector, we need to update every CommonJS consumer to import the named export instead of expecting the module itself to be the constructor. I will try to update consumers then
Coverage ReportIlc/serverCommit SHA:a962821552350a8e2b94aac2c42a243bd028f2eb Test coverage results 🧪File details
Ilc/clientCommit SHA:a962821552350a8e2b94aac2c42a243bd028f2eb Test coverage results 🧪File details
RegistryCommit SHA:a962821552350a8e2b94aac2c42a243bd028f2eb Test coverage results 🧪File details
|
stas-nc
approved these changes
Apr 2, 2026
wRLSS
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add response-level JS preload
Linkheaders for SSR-rendered fragment entry bundles in ILC.Previously,
ConfigsInjector#getAssetsToPreload()only returned stylesheet refs, so TailorX could not emit preload headers for fragment JS entry bundles. This change collects SSR fragmentspaBundleUrls, includes wrapper bundles when present, and passes them through to TailorX so they are exposed asLink: ... rel="preload"; as="script"response headers.Changes
request.router.getFragmentsContext()scriptRefsfromgetAssetsToPreload()Behavior
/_ilc/client.jsout of the response preload header set