Fix inconsistent wildcard behavior in outbound network policy rules#676
Draft
Copilot wants to merge 2 commits into
Draft
Fix inconsistent wildcard behavior in outbound network policy rules#676Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/nais/naiserator/sessions/dfb1c0c7-eae1-42bc-b7cf-b67da1d21b31 Co-authored-by: Starefossen <968267+Starefossen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix inconsistent application wildcard behaviour in ingress/egress
Fix inconsistent wildcard behavior in outbound network policy rules
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
application: '*'in outbound access policy rules was silently skipped, while the same wildcard in inbound rules correctly produced an emptypodSelector(match all). This meant the two configs below had different runtime behavior despite appearing equivalent in the NAIS console.Changes
networkpolicy.go: Remove theoutbound.Application == "*"skip condition inegressRulesFromAccessPolicy. Apply the same wildcard handling as inbound:*→ emptyLabelSelectorfor bothapplicationandnamespacefields.accesspolicy_max.yaml: Update existing test (which already hadapplication: '*', namespace: t2in outbound) to assert the expected wildcard egress rule is now generated.accesspolicy_egress_allow_all.yaml: New golden file test coveringapplication: '*', namespace: '*'outbound, producing egress with emptypodSelector: {}andnamespaceSelector: {}.Before / After