Quote SQL table identifiers to support special characters in event names#10
Open
joelhelbling wants to merge 1 commit into
Open
Quote SQL table identifiers to support special characters in event names#10joelhelbling wants to merge 1 commit into
joelhelbling wants to merge 1 commit into
Conversation
Event names containing hyphens (e.g., "pageview_docs_getting-started") caused SQL syntax errors because the hyphen was interpreted as subtraction. This wraps all dynamic table names in double quotes to treat them as identifiers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pageview_docs_getting-started)Problem
Event names containing special characters like
-caused the server to panic:This occurred in
DeleteEvents()and would affect any SQL query using dynamic table names.Test plan
curl -X POST http://localhost:3333/api/event/ -d '{"event": "test-event"}')🤖 Generated with Claude Code