Close MS19 Phase 4 (Visual Identity): x-prefix + mark complete#103
Conversation
Final brand walk verified — app surfaces (login/signup/dashboard/invoice create/public invoice) across screens, branded error pages, and the live marketing site (cryptozing.app already serves the new favicon + og card via the GitHub Pages placeholder; that's distinct from the MS21 app deploy). - 19.4 → x19.4_VISUAL_IDENTITY_POLISH.md (all items checked; Status: Complete). - Milestone doc: Phase 4 marked ✓ and dropped from active; favicon/og/copy exit criteria checked and reworded to the single-mark reality; added the error-pages (#96) exit criterion. Active phase is now Phase 3 (LLC) alone. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f553736f48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 5. [x] Public invoice view — `http://192.168.68.25/p/{token}` (use a real token from a sent invoice's print/share link) | ||
| 6. [x] Branded error page — http://192.168.68.25/nope → 404 _(eyeballed)_ | ||
| 7. [ ] Marketing homepage + Learn — https://cryptozing.app/ and https://cryptozing.app/learn/ _(post-deploy: favicon + og:image card + copy)_ | ||
| 7. [x] Marketing homepage + Learn — https://cryptozing.app/ and https://cryptozing.app/learn/ — already live on the GitHub Pages placeholder (auto-deploys on `site/` pushes, distinct from the MS21 app deploy). Homepage confirmed live, Learn locally; og card validated per §2.4–5. |
There was a problem hiding this comment.
Keep the Learn live check open until it is verified
This closes the marketing https://cryptozing.app/learn/ brand walk even though the evidence says “Learn locally”. The item is specifically for the live marketing homepage + Learn URLs, so if the Pages deploy is stale or missing the new favicon/OG/copy on /learn/, Phase 4 will now be marked complete without catching it; keep this unchecked or record a live /learn/ verification.
Useful? React with 👍 / 👎.
Final brand walk verified across screens (app surfaces, error pages, live marketing site). Renames 19.4 → x19.4 (Status: Complete, all items checked), marks Phase 4 ✓ in the milestone doc, and reconciles the favicon/og/copy exit criteria to the single-mark reality plus the error-pages (#96) criterion. Doc-only.
🤖 Generated with Claude Code