Feature MBEP#291 fix for 0 size requests#17
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a compilation/runtime issue in the Request constructor when PARAMETER_SIZE is 0 (e.g., ASN.1 types requiring 0 bytes for encoding), by guarding the memcpy with a constexpr check. Also adds project README content and the ESA-PL v2.3 LICENSE file.
Changes:
- Guard
memcpyinRequestconstructor withif constexpr (PARAMETER_SIZE > 0)to handle zero-size requests safely. - Expand
README.mdwith project description and ESA funding context. - Add
LICENSEfile (ESA-PL Permissive v2.3).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Request.h | Skip memcpy at compile-time when PARAMETER_SIZE == 0 to support zero-byte ASN.1 encodings and allow null data pointer. |
| README.md | Adds project description and ESA project funding references. |
| LICENSE | Adds full text of ESA-PL Permissive v2.3 license. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ficzer
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.