refactor(iroh): reduce warn logs#4378
Open
Frando wants to merge 1 commit into
Open
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4378/docs/iroh/ Last updated: 2026-06-29T09:43:06Z |
flub
reviewed
Jun 29, 2026
|
|
||
| impl std::fmt::Display for Box<dyn CustomEndpoint> { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| match self.watch_local_addrs().get().first() { |
Contributor
There was a problem hiding this comment.
This now creates locks for logging things. Which could be not great, as I expect these logs to come in bursts (noq-udp tries to avoid logging the same error twice within some time window to help with this IIRC). You do the same for IP but for some reason not for relay. If this were to avoid logging bursts than I wouldn't mind so much, but that's also more different complexity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce
WARNlogs we emit for failed sends or receives. These are normal under a few circumstances as numerous users reported. Let's demote them to debug under most circumstances.Breaking Changes
Notes & open questions
Change checklist
proposed change and wrote an as clear and concise description as
they could.
intented effect.