Support GitHub Enterprise Cloud data residency API URLs (*.ghe.com)#588
Open
sraisl wants to merge 1 commit intomyoung34:masterfrom
Open
Support GitHub Enterprise Cloud data residency API URLs (*.ghe.com)#588sraisl wants to merge 1 commit intomyoung34:masterfrom
sraisl wants to merge 1 commit intomyoung34:masterfrom
Conversation
Owner
|
The better fix is to set |
9422734 to
e7beaf2
Compare
Author
|
Updated this to avoid special-casing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub Enterprise Cloud with data residency uses API endpoints like:
https://api.<subdomain>.ghe.comThe current implementation treats all non-github.com hosts as GHES and uses:
https://<host>/api/v3This leads to invalid token generation and runner registration failures:
Invalid configuration provided for token
Solution
*.ghe.comhostshttps://api.<host>Impact
Closes #589