Increase code reuse with GenericFrameParser base classes - #71
Merged
Conversation
…pt, and Python Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor code to increase reuse with classes and templates
Increase code reuse with GenericFrameParser base classes
Dec 4, 2025
rijesha
marked this pull request as ready for review
December 4, 2025 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each frame format was generating nearly identical parser code. This refactors to use configuration-based generic parsers, reducing per-format code by ~78%.
Changes
GenericFrameParserclass,FrameParserConfiginterface, andcreateFrameParserClass()factoryGenericFrameParserclass,FrameParserConfigdataclass, andcreate_frame_parser_class()factoryframe_parser_ts_gen.pyandframe_parser_py_gen.pyto emit configuration-based codeBefore/After
Before (~160 lines per format):
After (~35 lines per format):
C/C++ already use shared inline functions from
frame_base.h, which is the idiomatic approach for those languages.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.