Add Wireshark dissector for struct-frame protocols - #119
Merged
Conversation
- Create struct_frame.lua dissector supporting all standard profiles - Support Basic and Tiny frame formats with automatic detection - Implement CRC validation with Fletcher-16 checksum - Add comprehensive README with installation and usage instructions - Create test packet generator script with sample PCAP output - Update main README with Wireshark dissector section - Add sample_packets/ to .gitignore Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
- Correct test packet generator to use Fletcher-16 checksum - Update packet validator to verify Fletcher-16 checksums - All test packets now validate correctly - Matches actual struct-frame implementation Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
rijesha
requested changes
Jan 5, 2026
| } | ||
| ``` | ||
|
|
||
| ## Wireshark Dissector |
Contributor
There was a problem hiding this comment.
@copilot Make this section a lot more brief. Most of the info should be in the wireshark readme and should be linked. It should be clear that this is experimental.
Contributor
Author
There was a problem hiding this comment.
Done in ae50b99. The Wireshark section is now brief (2 sentences), marked as experimental, and links to wireshark/README.md for detailed instructions.
- Document Fletcher-16 checksum algorithm - Explain what data is included in CRC calculation - Provide examples for each profile - Reference actual implementation from generated code - Validates that test implementation is correct Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
- Clarify None frame detection limitation with TODO comment - Improve DLT registration comment clarity - Remove misleading MAVLink port number example - Replace with generic port configuration example Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Wireshark dissector Lua plugin for default profiles
Add Wireshark dissector for struct-frame protocols
Jan 5, 2026
- Reduce Wireshark section in main README to 2 sentences - Mark dissector as experimental - Link to wireshark/README.md for detailed instructions - Remove features list, installation, and test data sections from main README Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
Contributor
Author
rijesha
marked this pull request as ready for review
January 5, 2026 17:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.