Added directory traversal#36
Open
dhruvsomani wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@myint Do you know if it's possible for cram to ignore whitespace differences? Because, I work on Windows and it's creating many errors dues to 'LF' and 'CRLF' differences (checked manually, they are all due to mismatching line endings). I converted the input to 'LF' style using [Edit] This looks like a pending issue. |
jayvdb
suggested changes
Nov 13, 2018
andrewda
suggested changes
Nov 13, 2018
andrewda
left a comment
andrewda
left a comment
There was a problem hiding this comment.
Looks good, just a couple small changes!
dhruvsomani
force-pushed
the
Directory
branch
from
4832132 to
2bac5a1
Compare
siddhpant
reviewed
Nov 13, 2018
This commit adds the possibility of traversing directories with scspell. Also, the command line argument `--ext` has been added and can be used more than once and all the files in the directories with those extensions will be checked. In case, the argument is not supplied, *all* the files in the directory and *subdirectories* would be checked. Example: ```scspell dir --ext py --ext txt``` Closes myint#22
dhruvsomani
force-pushed
the
Directory
branch
from
2bac5a1 to
7cdf108
Compare
myint
reviewed
Nov 18, 2018
| if not spell_check_file(f, dicts, ignores, report_only, c_escapes): | ||
| okay = False | ||
| else: | ||
| for dir, subdir, files in os.walk(f): |
Owner
There was a problem hiding this comment.
Same comment as @jayvdb about dir being reserved. I see that the code changed, but the name collision is still there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the possibility of traversing directories with scspell. Also, the command line argument
--exthas been added and can be used more than once and all the files in the directories with those extensions will be checked. In case, the argument is not supplied, all the files in the directory and subdirectories would be checked.Example:
scspell dir1 dir2 --ext py --ext txtThis checks for all
.pyand.txtfiles indir1anddir2.Closes #22