🎨 Palette: Enhance button semantics and input accessibility#151
🎨 Palette: Enhance button semantics and input accessibility#151myarichuk wants to merge 4 commits into
Conversation
…lity Adds `aria-label` to the search input in `Players.razor` which previously relied only on placeholder text, improving screen reader support. Also standardizes interactive `<button>` elements across `Home.razor`, `Grimoire.razor`, and `Players.razor` by explicitly assigning `type="button"`, preventing accidental form submissions. Recorded learning in `.Jules/palette.md`. Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…lity Adds `aria-label` to the search input in `Players.razor` which previously relied only on placeholder text, improving screen reader support. Also standardizes interactive `<button>` elements across `Home.razor`, `Grimoire.razor`, and `Players.razor` by explicitly assigning `type="button"`, preventing accidental form submissions. Recorded learning in `.Jules/palette.md`. Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
…lity Adds `aria-label` to the search input in `Players.razor` which previously relied only on placeholder text, improving screen reader support. Also standardizes interactive `<button>` elements across `Home.razor`, `Grimoire.razor`, and `Players.razor` by explicitly assigning `type="button"`, preventing accidental form submissions. Recorded learning in `.Jules/palette.md`. Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
…lity Adds `aria-label` to the search input in `Players.razor` which previously relied only on placeholder text, improving screen reader support. Also standardizes interactive `<button>` elements across `Home.razor`, `Grimoire.razor`, and `Players.razor` by explicitly assigning `type="button"`, preventing accidental form submissions. Recorded learning in `.Jules/palette.md`. Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
The application contained several minor accessibility and UX issues in its Blazor UI:
<input>inPlayers.razorrelied entirely on theplaceholderattribute to provide context, missing an explicit<label>oraria-label. This makes the field inaccessible or confusing for screen reader users.Home.razor,Grimoire.razor, andPlayers.razorwere implemented as<button>tags without an explicittypeattribute. In HTML,<button>defaults totype="submit", which can cause unintended side effects (like accidental page reloads) if these buttons are ever wrapped inside a<form>element.This PR addresses both issues:
aria-label="Search players or characters..."to the search input inPlayers.razor.type="button"to dozens of interactive buttons (add, delete, analyze, dismiss, generate, etc.) acrossPlayers.razor,Home.razor, andGrimoire.razorto enforce correct semantic behavior..Jules/palette.md.PR created automatically by Jules for task 16099775094637351108 started by @myarichuk