Skip to content

🎨 Palette: Enhance button semantics and input accessibility#151

Open
myarichuk wants to merge 4 commits into
mainfrom
palette-a11y-buttons-16099775094637351108
Open

🎨 Palette: Enhance button semantics and input accessibility#151
myarichuk wants to merge 4 commits into
mainfrom
palette-a11y-buttons-16099775094637351108

Conversation

@myarichuk

Copy link
Copy Markdown
Owner

The application contained several minor accessibility and UX issues in its Blazor UI:

  1. Accessibility (a11y) Issue: The search <input> in Players.razor relied entirely on the placeholder attribute to provide context, missing an explicit <label> or aria-label. This makes the field inaccessible or confusing for screen reader users.
  2. Semantic Issue: Numerous interactive clickable UI elements across Home.razor, Grimoire.razor, and Players.razor were implemented as <button> tags without an explicit type attribute. In HTML, <button> defaults to type="submit", which can cause unintended side effects (like accidental page reloads) if these buttons are ever wrapped inside a <form> element.

This PR addresses both issues:

  • Added aria-label="Search players or characters..." to the search input in Players.razor.
  • Added type="button" to dozens of interactive buttons (add, delete, analyze, dismiss, generate, etc.) across Players.razor, Home.razor, and Grimoire.razor to enforce correct semantic behavior.
  • Documented the learning regarding placeholder-only inputs in .Jules/palette.md.

PR created automatically by Jules for task 16099775094637351108 started by @myarichuk

…lity

Adds `aria-label` to the search input in `Players.razor` which previously relied only on placeholder text, improving screen reader support. Also standardizes interactive `<button>` elements across `Home.razor`, `Grimoire.razor`, and `Players.razor` by explicitly assigning `type="button"`, preventing accidental form submissions. Recorded learning in `.Jules/palette.md`.

Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules Bot and others added 3 commits July 7, 2026 03:05
…lity

Adds `aria-label` to the search input in `Players.razor` which previously relied only on placeholder text, improving screen reader support. Also standardizes interactive `<button>` elements across `Home.razor`, `Grimoire.razor`, and `Players.razor` by explicitly assigning `type="button"`, preventing accidental form submissions. Recorded learning in `.Jules/palette.md`.

Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
…lity

Adds `aria-label` to the search input in `Players.razor` which previously relied only on placeholder text, improving screen reader support. Also standardizes interactive `<button>` elements across `Home.razor`, `Grimoire.razor`, and `Players.razor` by explicitly assigning `type="button"`, preventing accidental form submissions. Recorded learning in `.Jules/palette.md`.

Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
…lity

Adds `aria-label` to the search input in `Players.razor` which previously relied only on placeholder text, improving screen reader support. Also standardizes interactive `<button>` elements across `Home.razor`, `Grimoire.razor`, and `Players.razor` by explicitly assigning `type="button"`, preventing accidental form submissions. Recorded learning in `.Jules/palette.md`.

Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant