feat(ui): improve accessibility and empty state on players page#146
feat(ui): improve accessibility and empty state on players page#146myarichuk wants to merge 1 commit into
Conversation
- Add `aria-label` to the search input for better screen reader support. - Set `type="button"` on action buttons to prevent default form submission behavior. - Apply `text-tertiary` and margin-bottom classes to the empty state paragraph to match design patterns. Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎨 Palette: Improve Players Page Accessibility and Empty State
💡 What:
aria-labelto the search input.type="button"attributes to the "Analyze Party" and "Add Player" buttons..text-tertiaryclass and.mb-4spacing.🎯 Why:
typeattribute, which could unintentionally trigger form submissions if placed inside or near a form..text-tertiaryfor explanatory empty state text).📸 Before/After:
Visually, the empty state text is now correctly styled as tertiary text, and keyboard/screen reader users can now properly identify the search input.
♿ Accessibility:
PR created automatically by Jules for task 3012329362149405755 started by @myarichuk