Skip to content

feat(ui): improve accessibility and empty state on players page#146

Open
myarichuk wants to merge 1 commit into
mainfrom
palette/players-a11y-empty-state-3012329362149405755
Open

feat(ui): improve accessibility and empty state on players page#146
myarichuk wants to merge 1 commit into
mainfrom
palette/players-a11y-empty-state-3012329362149405755

Conversation

@myarichuk

Copy link
Copy Markdown
Owner

🎨 Palette: Improve Players Page Accessibility and Empty State

💡 What:

  • Added an aria-label to the search input.
  • Added explicit type="button" attributes to the "Analyze Party" and "Add Player" buttons.
  • Updated the empty state descriptive text with the .text-tertiary class and .mb-4 spacing.

🎯 Why:

  • The search input was missing a descriptive label for screen readers.
  • The action buttons lacked a type attribute, which could unintentionally trigger form submissions if placed inside or near a form.
  • The empty state text typography and spacing were inconsistent with the repository's design system patterns (which uses .text-tertiary for explanatory empty state text).

📸 Before/After:
Visually, the empty state text is now correctly styled as tertiary text, and keyboard/screen reader users can now properly identify the search input.

Accessibility:

  • Screen readers will now announce "Search players or characters" when focusing the search input instead of just reading the placeholder or ignoring it.

PR created automatically by Jules for task 3012329362149405755 started by @myarichuk

- Add `aria-label` to the search input for better screen reader support.
- Set `type="button"` on action buttons to prevent default form submission behavior.
- Apply `text-tertiary` and margin-bottom classes to the empty state paragraph to match design patterns.

Co-authored-by: myarichuk <1473701+myarichuk@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant