[Feature] Generate and inject output blocks for litdoc cells#4
Merged
Conversation
mwittie
changed the title
# Conflicts: # cmd/file.go # cmd/testdata/script/file.txtar # internal/block.go # internal/block_test.go # internal/cell.go # internal/cell_test.go
Owner
Author
|
I'm updated how indented blocks are scanned in #7, so this PR needs to be pulled back |
cmd/testscript_test.go no longer uses the built binary, so we can remove that dependency
The "got" field in the error message was using b.content (the whitespace prefix text) twice. For inline-split marker prefixes, b.indent is the structural indent value that should be reported as the actual value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implements execution of litdoc-tagged fenced code blocks and injection of their output into the markdown document.
BashCell.Executeruns the fenced code and wraps output in<!-- BEGIN LITDOC OUTPUT --> / <!-- END LITDOC OUTPUT -->markersClassifyscans existing output blocks following a litdoc cell back intoBashCell.output, so re-running is idempotentOutputvalue type centralises rendering and parsing of output blocks;OutputFromBlockshandles the tree-sitter-split multi-block representationNotes for reviewers
BashCell.Executeis still a stub that always returns"output"— real shell execution is the next step.Checklist before requesting a review
If any of these checks are missing, please provide an explanation.