Skip to content

chore: add lefthook with fmt, clippy, and test hooks#17

Merged
mvoof merged 2 commits into
mainfrom
chore/lefthook
Jun 27, 2026
Merged

chore: add lefthook with fmt, clippy, and test hooks#17
mvoof merged 2 commits into
mainfrom
chore/lefthook

Conversation

@mvoof

@mvoof mvoof commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Closed #16

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Lefthook git hooks to automate formatting, linting, and testing, and updates the contribution guidelines accordingly. Feedback on these changes highlights potential race conditions from running fmt and clippy in parallel with stage_fixed: true, the risks of automatically running clippy --fix during pre-commit, and a broken list numbering sequence in the updated CONTRIBUTING.md file.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lefthook.yml Outdated
Comment thread lefthook.yml Outdated
Comment thread CONTRIBUTING.md Outdated
@mvoof mvoof merged commit 0c06301 into main Jun 27, 2026
1 check passed
@mvoof mvoof deleted the chore/lefthook branch June 27, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add format, lint, test, check on commit with lefthook

1 participant